-
Notifications
You must be signed in to change notification settings - Fork 630
ci: Do not push latest tag on Docker images #1744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed 'latest' tag from multiple Docker image builds in the workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the 'latest' tag from Docker image builds across all services in the CI workflow to improve version control and prevent accidental deployment of unstable builds.
- Removes 'latest' tag from all Docker image build steps
- Maintains explicit versioning through IMAGE_TAG environment variable
- Affects both DockerHub (scrolltech) and ECR registry pushes
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
WalkthroughThe Docker GitHub Actions workflow was updated to stop pushing images tagged as :latest. Only the specific IMAGE_TAG is now pushed to registries. No other steps, jobs, or control flow in the workflow were changed. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant B as Docker Buildx
participant R as Registry
Dev->>GH: Push/Tag triggers workflow
GH->>B: Build image
B-->>GH: Image artifact
GH->>R: Push tag: scrolltech/${REPOSITORY}:${IMAGE_TAG}
note over R: No push of :latest tag
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
Purpose or design rationale of this PR
Removed 'latest' tag from multiple Docker image builds in the workflow.
This tag is brittle and error-prone. E.g. when we push tags on unstable feature branches, the new images are also tagged as latest. It is better to remove this tag and always rely on explicit image versions.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit