Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new AxiomProgram struct to encapsulate both program IDs and their associated configuration IDs, replacing the previous approach of storing only program IDs as strings.
Key Changes:
- Added
AxiomProgramstruct withprogram_idandconfig_idfields - Implemented convenience constructors for chunk, batch, and bundle configurations
- Updated
program_idsstorage to useAxiomPrograminstead of plain strings
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/types/src/axiom.rs | Defines new AxiomProgram struct with getters and factory methods for different config types |
| crates/tools/upload-axiom/src/main.rs | Updates program ID storage to use AxiomProgram struct and adds import for new type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lispc
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.