Skip to content

Comments

Feat: Euclid Phase2#43

Merged
lispc merged 28 commits intomasterfrom
feat/phase2
Mar 14, 2025
Merged

Feat: Euclid Phase2#43
lispc merged 28 commits intomasterfrom
feat/phase2

Conversation

@roynalnaruto
Copy link
Collaborator

@roynalnaruto roynalnaruto commented Feb 27, 2025

Commits

  • feat: batch header as per da-codec v7

  • Phase2 miscellaneous additions (Phase2 miscellaneous additions #26)

  • public inputs, todos, v7 codec for env/payload

  • feat: update chunk-circuit witness to accept prev msg queue hash

  • feat: update chunk proving task

  • feat: add block ctx to chunk info

  • fix: compilation and update sbv+revm

  • [Feat] point evaluation ([Feat] point evaluation #27)

  • point eval in batch: setup for dependencies

  • point eval utility in prover

  • refactoring challenge generation

  • kzg verify with openvm

  • WIP: add test for kzg verify

  • pass tests

  • fix feature error

  • restore v7

  • clean up dep and clippy

  • update according to reviews

  • more fix according to review

  • fix according to reviews and fmt

  • more cleanup, chore and fmt

  • api fix

  • batch builder (still wip)

  • payload validation api

  • payload validation impl

  • chore: minor refactor

  • fix: add block number check

  • feat: add block ctx to chunk pi

  • chore: remove unused module

  • fix integration

  • fix: remove initial l1 msg index from blob payload

  • make bundle circuit can build

  • chore: update cargo lock with sbv updates

  • update openvm config of batch

  • resolve transpile error

  • update sbv

  • patch reth locally and upgrade dep

  • correct the revm patch

  • fix

  • update chunk test data

  • use robust chain spec in test

  • temporary fix chainspec

  • refactor: move payload to type and feature some dep out

  • some trivial fixing

  • fix paring payload, update test data

  • fix issues and pass execute test

  • prepare for e2e

  • enable pairing proof

  • update sbv, fix wrong prev state root

  • update task data

  • update test sample data

  • revert path

  • fix crate patching

  • update trace json

  • fix build

  • pin munge version.. wtf rust 2024

  • fix bundle info

  • update test sample data and commitment

  • fix bundle proof gen

  • cleanup, refactor (cleanup, refactor #42)

@roynalnaruto @noel2004
@lightsing @lispc
batch header (da-codec v7) (#25)
51847c9 
* feat: batch header as per da-codec v7

* Phase2 miscellaneous additions (#26)

* public inputs, todos, v7 codec for env/payload

* feat: update chunk-circuit witness to accept prev msg queue hash

* feat: update chunk proving task

* feat: add block ctx to chunk info

* fix: compilation and update sbv+revm

* [Feat] point evaluation (#27)

* point eval in batch: setup for dependencies

* point eval utility in prover

* refactoring challenge generation

* kzg verify with openvm

* WIP: add test for kzg verify

* pass tests

* fix feature error

* restore v7

* clean up dep and clippy

* update according to reviews

* more fix according to review

* fix according to reviews and fmt

* more cleanup, chore and fmt

* api fix

* batch builder (still wip)

* payload validation api

* payload validation impl

* chore: minor refactor

* fix: add block number check

* feat: add block ctx to chunk pi

* chore: remove unused module

* fix integration

* fix: remove initial l1 msg index from blob payload

* make bundle circuit can build

* chore: update cargo lock with sbv updates

* update openvm config of batch

* resolve transpile error

* update sbv

* patch reth locally and upgrade dep

* correct the revm patch

* fix

* update chunk test data

* use robust chain spec in test

* temporary fix chainspec

* refactor: move payload to type and feature some dep out

* some trivial fixing

* fix paring payload, update test data

* fix issues and pass execute test

* prepare for e2e

* enable pairing proof

* update sbv, fix wrong prev state root

* update task data

* update test sample data

* revert path

* fix crate patching

* update trace json

* fix build

* pin munge version.. wtf rust 2024

* fix bundle info

* update test sample data and commitment

* fix bundle proof gen

* cleanup, refactor (#42)

---------

Co-authored-by: Rohit Narurkar <rohit.narurkar@proton.me>
Co-authored-by: lightsing <light.tsing@gmail.com>
Co-authored-by: Zhuo Zhang <mycinbrin@gmail.com>

---------

Co-authored-by: Ho <fan@scroll.io>
Co-authored-by: lightsing <light.tsing@gmail.com>
Co-authored-by: Zhuo Zhang <mycinbrin@gmail.com>

---------

Co-authored-by: Ho <fan@scroll.io>
Co-authored-by: lightsing <light.tsing@gmail.com>
Co-authored-by: Zhuo Zhang <mycinbrin@gmail.com>
@roynalnaruto roynalnaruto changed the title batch header (da-codec v7) (#25) Feat: Euclid Phase2 Feb 27, 2025
@github-actions github-actions bot added crate-chunk-circuit Updates to the guest program chunk-circuit crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-prover Updates to the prover crate crate-integration Updates to the integration crate crate-build-guest Updates to building of guest programs crate-circuits Any update made to the circuits, i.e. commitments reflect a change labels Mar 5, 2025
@github-actions github-actions bot added the crate-verifier Updates to the verifier crate label Mar 5, 2025
@roynalnaruto
Print total_cycles in PR description (#54)
7c8023c 
* test: get cycle count

* entry in makefile

* ci: profile guest (chunk-circuit)

* allow manual dispatch for build guest
@github-actions github-actions bot added the ci CI related updates label Mar 6, 2025
roynalnaruto and others added 11 commits March 6, 2025 02:32
@roynalnaruto
fix(ci): use v4 for upload/download artifact
ce7d4a2
@roynalnaruto
Merge branch 'master' into feat/phase2
c0c1170
@roynalnaruto
chore: update commitments (after resolve conflicts)
c5781b6
@noel2004 @roynalnaruto
@lispc @lightsing
Feat/unify fork 2 (#56)
230ca2a 
* feat: batch header as per da-codec v7

* public inputs, todos, v7 codec for env/payload

* feat: update chunk-circuit witness to accept prev msg queue hash

* feat: update chunk proving task

* point eval in batch: setup for dependencies

* point eval utility in prover

* refactoring challenge generation

* kzg verify with openvm

* feat: add block ctx to chunk info

* WIP: add test for kzg verify

* pass tests

* fix feature error

* restore v7

* clean up dep and clippy

* update according to reviews

* more fix according to review

* fix: compilation and update sbv+revm

* fix according to reviews and fmt

* more cleanup, chore and fmt

* api fix

* batch builder (still wip)

* payload validation api

* payload validation impl

* chore: minor refactor

* fix: add block number check

* feat: add block ctx to chunk pi

* chore: remove unused module

* fix integration

* fix: remove initial l1 msg index from blob payload

* make bundle circuit can build

* chore: update cargo lock with sbv updates

* update openvm config of batch

* resolve transpile error

* refactor test_execute; make AggStarkProvingKey lazy

* update sbv

* patch reth locally and upgrade dep

* correct the revm patch

* fix

* profiling

* refactor

* fix

* update chunk test data

* use robust chain spec in test

* temporary fix chainspec

* refactor: move payload to type and feature some dep out

* some trivial fixing

* fix paring payload, update test data

* old chunk

* fix

* fix

* fix

* minor

* fix issues and pass execute test

* prepare for e2e

* enable pairing proof

* refactor build-guest

* support for bincode; but not enable

* fix all these shit patching

* muild

* minor

* update sbv, fix wrong prev state root

* update task data

* update test sample data

* revert path

* fix 7702 sig patch; add cycle test

* fix crate patching

* update trace json

* fix build

* pin munge version.. wtf rust 2024

* fix bundle info

* update test sample data and commitment

* fix bundle proof gen

* update cargo lock

* fmt euclid v1 traces

* update Makefile

* disable p256

* cleanup, refactor (#42)

* bump openvm; but cycle too hight

* wtf

* unify phases for batch circuit

* code can compiled for pre-v2

* enable specify project name

* fix default feature issue

* seems good

* minor

* build

* minor

* complete build task for pre-v2

* clean testdata

* batch data test support pre-v2 data

* fmt

* update test data, fix e2e issue in pre-v2

* fix chunk build issue

* fix chain spec for pre-v2

* fix LazyLock<Mainnet>

* enable lto=fat for guest

* fix bui;d

* fix merge conflicts

* update makefile for legacy build

* fix building

* fix tests

* purge bincode feature

* handling FIXME

* revert profiling refactors

* adjusting features

* trivial fixings

* update testdata, fix feature issue

* disable pairing temporarily

* separate commitment of phase1 and phase2, update commitments

* fix clippy

---------

Co-authored-by: Rohit Narurkar <rohit.narurkar@proton.me>
Co-authored-by: Zhuo Zhang <mycinbrin@gmail.com>
Co-authored-by: lightsing <light.tsing@gmail.com>
@noel2004
refactor: misc fix (#67)
9f48bc4 
* trivial fixes according to review

* add compatible test for phase 1 batch task
@lispc
opt: dedup trie nodes and bytecodes in chunk witness
855fcef
@lispc
upgrade openvm
9d62584
@noel2004
do not need to clean docker container manually (#74)
903c26c
@lispc
feat: refactor exec_guest, tested with a 88M gas chunk (#80)
0058fb3 
* init

* clean cargo toml

* fix

* cargo

* fix

* lint and commitment

* perf: timestamp is per segment

* lint
@noel2004 @roynalnaruto
Sanity check for commitment in verifier (#71)
7240be7 
* sanity check of commitment for verifier

* more test

* ignore tests

* fix build issue

* trivial updates

* cleanup, refactor

* update test assets

* fix issue in bundle e2e

* refactor: always check program commitment in each proof generation

* fmt

* sanity check for evm proof

* fix: build-guest issue

* fix and fmt

* always sanity check when prover is inited

---------

Co-authored-by: Rohit Narurkar <rohit.narurkar@proton.me>
@noel2004
fix feature issue in integration
fbefb34
@lispc lispc merged commit dc20b05 into master Mar 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lispc lispc lispc approved these changes

@noel2004 noel2004 Awaiting requested review from noel2004 noel2004 is a code owner

@lightsing lightsing Awaiting requested review from lightsing lightsing is a code owner

Assignees

No one assigned

Labels

ci CI related updates crate-batch-circuit Updates to the guest program batch-circuit crate-build-guest Updates to building of guest programs crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-chunk-circuit Updates to the guest program chunk-circuit crate-circuits Any update made to the circuits, i.e. commitments reflect a change crate-integration Updates to the integration crate crate-prover Updates to the prover crate crate-verifier Updates to the verifier crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roynalnaruto @lispc @noel2004