Print total_cycles in PR description#54
Merged
roynalnaruto merged 4 commits intofeat/phase2from Mar 6, 2025
Merged
Conversation
github-actions
bot
added
crate-prover
roynalnaruto
changed the title
cycle_count betweentotal_cycles in PR description
lispc
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes we may end up using an incorrect patch or set an incorrect config for OpenVM. As we add more features and support more EIPs/RIPs via
revmand OpenVM extensions, it is important to monitor the total cycles taken to prove a single chunk (fromtestdata) to make sense of a possible config/patch issue.The
profile-guest.ymlworkflow will run every time thebuild-guestyml` workflow succeeds and adds the "total cycles" for the chunk-circuit in the PR's description for convenient review.