-
Notifications
You must be signed in to change notification settings - Fork 702
DensMAP support #2946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keller-mark
wants to merge
56
commits into
scverse:main
Choose a base branch
from
keller-mark:keller-mark/densmap-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+179
−9
Open
DensMAP support #2946
Changes from 23 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
4bd98b6
Add docstrings
keller-mark b55fa95
More tests
keller-mark e1a0797
Fixes for tests
keller-mark f140bda
Typo
keller-mark 745e79e
Linting
keller-mark c63e745
Ruff
keller-mark 66cf7fd
More linting
keller-mark d705887
More linting
keller-mark af32d85
Merge branch 'main' into keller-mark/densmap-2
keller-mark ec2b6d9
Update references.bib
keller-mark b41ddbd
Update references.bib
keller-mark 86a0df0
Merge
keller-mark 335d5a9
Merge branch 'keller-mark/densmap-2' of github.com:keller-mark/scanpy…
keller-mark 6ee89e7
Fix bug
keller-mark 603afb3
Update
keller-mark a2bbcf8
Merge branch 'main' of github.com:keller-mark/scanpy into keller-mark…
keller-mark 4d15620
Relese note
keller-mark e8350d2
Formatting
keller-mark 9030cb4
Try pre-commit
keller-mark 967da92
Fix random_State type
keller-mark b70ec7e
Refactor type
keller-mark 1784fa4
Fix citation format
keller-mark e92785e
Fix bibtex key
keller-mark 2ce47d6
Use partial to implement sc.tl.densmap
keller-mark 5838162
Update params in test
keller-mark ba2e887
Revert convenience sc.tl.densmap
keller-mark dffadfe
Add image plotting test
keller-mark 44cfafc
Fix variable naming in test
keller-mark 0507434
Merge branch 'main' of github.com:scverse/scanpy into keller-mark/den…
keller-mark e4b81f5
Frameon
keller-mark 0ec47b3
Revert frameon change
keller-mark 4f3ae06
Merge branch 'main' into keller-mark/densmap-2
keller-mark faaf5ae
Merge branch 'main' of github.com:scverse/scanpy into keller-mark/den…
keller-mark 4152565
Change type name
keller-mark 3d73310
Merge
keller-mark 8f8787a
Check if specific to densmap
keller-mark 3b68fe2
Add expected image
keller-mark 8d45d49
Skipif for numba
keller-mark 3cc91fc
Use pkg_version
keller-mark e8e00e6
Update .azure-pipelines.yml
ilan-gold 5df86ac
Update .azure-pipelines.yml
ilan-gold 5c2be1e
Update .azure-pipelines.yml
ilan-gold 1e4ac26
Update .azure-pipelines.yml
ilan-gold 0f20962
Merge branch 'main' into keller-mark/densmap-2
keller-mark e40d9f7
Add numerical test for densmap. Add test for raises ValueError
keller-mark 7a8b637
Merge with main
keller-mark a8f7bb4
Remove unused image fixtures
keller-mark 99390f9
Update tests/test_embedding.py
keller-mark 3777672
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b262bc2
WIP: try adding types
keller-mark f8f0fb6
Merge branch 'keller-mark/densmap-2' of github.com:keller-mark/scanpy…
keller-mark f921dcc
Merge branch 'main' into keller-mark/densmap-2
keller-mark 019035d
Merge branch 'main' into keller-mark/densmap-2
keller-mark b0df27e
Merge branch 'main' into keller-mark/densmap-2
keller-mark 4967a00
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 22fb7a7
Fix import statement for _LegacyRandom
keller-mark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add DensMAP support with {func}`~scanpy.tl.densmap` {smaller}`M Keller` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from typing import TypedDict | ||
|
|
||
|
|
||
| class UmapMethodKwds(TypedDict, total=False): | ||
| dens_lambda: float | ||
| dens_frac: float | ||
| dens_var_shift: float | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.