-
Notifications
You must be signed in to change notification settings - Fork 710
Add cluster_resolution_finder and cluster_decision_tree for help deciding the proper resolution #3532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joe-jhou2
wants to merge
39
commits into
scverse:main
Choose a base branch
from
joe-jhou2:feature-cluster-decision-tree
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add cluster_resolution_finder and cluster_decision_tree for help deciding the proper resolution #3532
Changes from 14 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
b37477c
Add cluster_decision_tree and cluster_resolution_finder with tests
joe-jhou2 88306f6
Fix formatting issue
joe-jhou2 4cd3134
igraph install
joe-jhou2 0b2f126
formatting fix
joe-jhou2 6126013
Restructure cluster_resolution_finder and cluster_decision_tree to fo…
joe-jhou2 12cf89d
Register mpl_image_compare marker in pyproject.toml for pytest-mpl
joe-jhou2 25569b2
Merge branch 'main' into feature-cluster-decision-tree
joe-jhou2 1aadcc4
comment out one test
joe-jhou2 69b16c7
suppress print statements during testing
joe-jhou2 70dea35
suppress print statements during testing
joe-jhou2 8e25dfc
Merge branch 'main' into feature-cluster-decision-tree
joe-jhou2 c74cd1a
Fix the check-milestone workflow
joe-jhou2 a91e9f1
Fix the check-milestone workflow
joe-jhou2 bc5dd9f
restore check-milestone workflow
joe-jhou2 f595f5d
Merge branch 'main' into feature-cluster-decision-tree
flying-sheep e422ad1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5932717
WIP: save changes before pulling
joe-jhou2 d6d4e72
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ce51530
fix ruff error
joe-jhou2 c084342
fix ruff error
joe-jhou2 9d6dd21
Merge branch 'main' into feature-cluster-decision-tree
joe-jhou2 6e19de7
refactror main function to class
joe-jhou2 3eb806a
Merge branch 'feature-cluster-decision-tree' of https://github.com/jo…
joe-jhou2 da8f6f4
Merge branch 'main' into feature-cluster-decision-tree
joe-jhou2 ac54dfd
refactror main function to class
joe-jhou2 0cffc68
refactror main function to class
joe-jhou2 44cc72f
Defer networkx import
flying-sheep 34d9f1c
Merge branch 'main' into feature-cluster-decision-tree
joe-jhou2 e171c8c
Skip TC004 warning for now
joe-jhou2 a0ff151
Skip TC004 warning for now
joe-jhou2 202280e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 00e10c8
Skip TC004 warning for now
joe-jhou2 2d60321
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 01a1e87
modify seaborn import
joe-jhou2 20bf0a8
modify seaborn import
joe-jhou2 2644a42
Merge branch 'scverse:main' into feature-cluster-decision-tree
joe-jhou2 1f4c098
add verbose to find_cluster_resolution
joe-jhou2 e460214
Merge branch 'scverse:main' into feature-cluster-decision-tree
joe-jhou2 7ee7bac
Merge branch 'main' into feature-cluster-decision-tree
joe-jhou2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,3 +45,5 @@ Thumbs.db | |
| # asv benchmark files | ||
| /benchmarks/.asv | ||
| /benchmarks/data/ | ||
| myenv/ | ||
| test.py | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,4 +19,5 @@ | |
| "python.testing.pytestArgs": ["-vv", "--color=yes"], | ||
| "python.testing.pytestEnabled": true, | ||
| "python.terminal.activateEnvironment": true, | ||
| "git.ignoreLimitWarning": true, | ||
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scanpy/pyproject.toml
Lines 95 to 98 in bdcef41
the leidenalg package is already part of the
testextra, which means it will be installed in all test jobs except for thetest-minone. This should stay that way.please revert your changes to this workflow and instead add a marker to all tests that need leidenalg to run, using this helper:
There are two ways to do this:
@needs.leidenalgpytestmark = [needs.leidenalg]to the top of your test file (below the imports)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add pytestmark = [needs.leidenalg] on the top for test file.