Skip to content

Remove reference cycle within SpatialData to fix memory leak in bounding_box_query #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove reference cycle within SpatialData to fix memory leak in bounding_box_query #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/spatialdata/_core/spatialdata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,6 @@ def __init__(
self.validate_table_in_spatialdata(v)
self.tables[k] = v

self._query = QueryManager(self)

def validate_table_in_spatialdata(self, table: AnnData) -> None:
"""
Validate the presence of the annotation target of a SpatialData table in the SpatialData object.
Expand Down Expand Up @@ -525,7 +523,7 @@ def query(self) -> QueryManager:
spatialdata.bounding_box_query
spatialdata.polygon_query
"""
return self._query
return QueryManager(self)

def aggregate(
self,
Expand Down
Loading