-
Notifications
You must be signed in to change notification settings - Fork 70
support zarrv3 #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
support zarrv3 #985
Conversation
version is not supported by zarr v3.0.8
* refactor read_zarr * remove unneccesary checks
* refactor read_zarr * remove unneccesary checks * emit warning with old spatialdata storage version detected
@falexwolf @Zethson @BioinfoTongLI, waiting for small review of last few commits from Luca. PR description states most of the user facing changes, but should not be too different. I noticed that right now the formats can only be imported from private module. I will move these to the public API and provide docs in a future PR soon. @falexwolf or @Zethson does this PR now still work with all your workflows? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
==========================================
- Coverage 92.36% 92.12% -0.25%
==========================================
Files 48 48
Lines 7416 7469 +53
==========================================
+ Hits 6850 6881 +31
- Misses 566 588 +22
🚀 New features to boost your workflow:
|
This PR provides initial support for Zarr v3 in SpatialData. These changes include the following:
format
argument for writing operations will be deprecated in version 0.7.0 as format is a Python builtin,Please use
sdata_formats
instead, argument type stays the same.SpatialData
. This is added because if SpatialData is written with consolidated metadata and this metadata gets corrupted, the zarr store cannot be opened. Settingreconsolidate_metadata
toTrue
when reading, will rewrite the consolidated metadata store after which is then should be possible to open the zarr store again.SpatialData
zarr store is read and detected to be stored in the old format, a warning is given to the user. Users can silence this with this PR only when they rewrite theSpatialData
object to a new location. In a next PR, we will enable rewriting solely the metadata if possible (if the user did not store using sharding).