Skip to content

Conversation

@selmanozleyen
Copy link
Member

fixes: #1104

@selmanozleyen selmanozleyen changed the title increase timeout increase test_parallelize timeout Jan 29, 2026
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.21%. Comparing base (6ad2373) to head (0022298).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1105   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files          44       44           
  Lines        7163     7163           
  Branches     1217     1217           
=======================================
  Hits         4743     4743           
  Misses       1943     1943           
  Partials      477      477           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@selmanozleyen selmanozleyen self-assigned this Feb 2, 2026
@flying-sheep
Copy link
Member

flying-sheep commented Feb 2, 2026

No, that makes no sense, adding 100 integers together should timeout after 30ms not 30s.

@selmanozleyen
Copy link
Member Author

I am not sure, it was always problematic. I recently noticed also fails locally when backend is not loky which is skipped in CI. Is it ok if I have an issue about this and we just merge for now? so that the CI's arent flaky for now

@flying-sheep
Copy link
Member

flying-sheep commented Feb 2, 2026

If restarting helps, you can try @pytest.mark.flaky(reruns=5) or so (and as said, reduce the timeout to a second max).

@flying-sheep
Copy link
Member

Like this is clearly broken, more timeout won’t help.

@selmanozleyen
Copy link
Member Author

ok it passes, thank you !

@selmanozleyen
Copy link
Member Author

@flying-sheep I created an issue here #1111 could we just merge it for now?

@flying-sheep flying-sheep changed the title increase test_parallelize timeout ci: mark test_parallelize as flaky Feb 3, 2026
@flying-sheep flying-sheep merged commit fb90f03 into scverse:main Feb 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test parallelize timeouts often

2 participants