Skip to content

Conversation

@selmanozleyen
Copy link
Member

@selmanozleyen selmanozleyen commented Jan 29, 2026

This will fix #1100 and fixes #1099. Errors can be reproduced when pd.options.mode.copy_on_write = True

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.21%. Comparing base (fb90f03) to head (a430855).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1106   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files          44       44           
  Lines        7163     7163           
  Branches     1217     1217           
=======================================
  Hits         4743     4743           
  Misses       1943     1943           
  Partials      477      477           
Files with missing lines Coverage Δ
src/squidpy/gr/_niche.py 32.28% <100.00%> (ø)
src/squidpy/tl/_sliding_window.py 75.86% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@selmanozleyen selmanozleyen requested review from flying-sheep, ilan-gold and timtreis and removed request for flying-sheep January 29, 2026 12:56
Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check the actual runtime configuration, I think, for users who haven't upgraded if keeping old behavior is in your interest: https://pandas.pydata.org/docs/user_guide/copy_on_write.html#migrating-to-copy-on-write

@selmanozleyen
Copy link
Member Author

hi this is already backward compatible since I just replaced in chained assignment. With 3.0 it just causes bugs doesn't raise version related explicit errors.

@selmanozleyen selmanozleyen merged commit 469a7d0 into scverse:main Feb 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration Testing CI Test Failure on python 3.12 Integration Testing CI Test Failure on python 3.13

2 participants