Skip to content

fix the bug of relative coordinates #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix the bug of relative coordinates #572

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
679214f
fix the bug of relative coordinates
JiaShun-Xiao Jun 17, 2022
e2ca958
Merge branch 'main' into main
giovp Aug 9, 2022
06964fc
Merge branch 'main' into main
giovp Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions squidpy/im/_feature_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,12 +351,12 @@ def convert_to_full_image_coordinates(x: NDArrayA, y: NDArrayA) -> NDArrayA:
y_slc, x_slc = coord.to_image_coordinates(padding).slice

# relative coordinates
y = (y - np.min(y)) / (np.max(y) - np.min(y))
x = (x - np.min(x)) / (np.max(x) - np.min(x))
#y = (y - np.min(y)) / (np.max(y) - np.min(y))
#x = (x - np.min(x)) / (np.max(x) - np.min(x))

# coordinates in the uncropped image
y = coord.slice[0].start + (y_slc.stop - y_slc.start) * y
x = coord.slice[1].start + (x_slc.stop - x_slc.start) * x
y = coord.slice[0].start + y#(y_slc.stop - y_slc.start) * y
x = coord.slice[1].start + x#(x_slc.stop - x_slc.start) * x

return np.c_[x, y] # type: ignore[no-any-return]

Expand Down