Open
Conversation
29 tasks
wprzytula
reviewed
Mar 12, 2026
Comment on lines
61
to
+64
| permissions: | ||
| pages: write # to deploy to Pages | ||
| id-token: write # to verify the deployment originates from an appropriate source | ||
| contents: read # to read private repo | ||
| contents: write # to read private repo |
Contributor
There was a problem hiding this comment.
🔧 You change the permission, but the comment is unchanged.
| description = "ScyllaDB CPP RS Driver Documentation" | ||
| authors = [{ name = "ScyllaDB Documentation Contributors" }] | ||
| requires-python = ">=3.10" | ||
| requires-python = ">=3.12" |
Contributor
There was a problem hiding this comment.
❓ In the cover letter you mention Python >= 3.10, here >= 3.12. Why the discrepancy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Updates docs theme to 1.9.
Changelog: https://github.com/scylladb/sphinx-scylladb-theme/blob/master/docs/source/upgrade/CHANGELOG.md#190---26-february-2026
How to test
Make sure you are using Python 3.11-3.14:
Install uv:
Build the docs:
Docs should render without errors at http://127.0.0.1:5500