Skip to content

errors: Make Rust errors conversion to CassError more appropriate #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 4, 2025
Merged

errors: Make Rust errors conversion to CassError more appropriate #352

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
17f662f
tree: merge execution_error.rs into cass_error.rs
wprzytula Jul 27, 2025
7080901
cass_error: return INVALID_DATA where appropriate
wprzytula Jul 28, 2025
9140385
cass_error: stop abusing server protocol error
wprzytula Jul 28, 2025
a3c6827
cass_error: BadQuery -> MESSAGE_ENCODE conversion
wprzytula Jul 28, 2025
3f9351b
cass_error: MetadataError better conversion
wprzytula Jul 28, 2025
fd0131a
cass_error: BadKeyspaceName -> UNABLE_TO_SET_KEYSPACE
wprzytula Jul 28, 2025
3ab3159
cass_error: SerializationError -> INVALID_DATA
wprzytula Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scylla-rust-wrapper/src/cass_error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ impl ToCassError for SerializationError {
// It means that our custom `UnknownNamedParameterError` was returned.
CassError::CASS_ERROR_LIB_NAME_DOES_NOT_EXIST
} else {
CassError::CASS_ERROR_LAST_ENTRY
CassError::CASS_ERROR_LIB_INVALID_DATA
}
}
Comment on lines 257 to 262
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit: "cass_error: SerializationError -> INVALID_DATA "

When is LIB_INVALID_DATA appropriate vs LIB_MESSAGE_ENCODE?

Copy link
Collaborator Author

@wprzytula wprzytula Aug 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My vague understanding of it is that when the particular CQL value is of bad type or corrupted, then INVALID_DATA is appropriate. MESSAGE_ENCODE is more about CQL protocol limitations, such as too big number of values, too many statements in a batch etc.

}
Expand Down