(improvement) remove redundant len() calls from compression code #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very similar changes to the Python driver (scylladb/python-driver#520 ), there are redundant calls to len(). Removed them. Follow-up patch will hopefully change the Encode() functions to accept the length of the buffer, to remove another len() call (just as done in the Python change mentioned above). Signed-off-by: Yaniv Kaul <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant calls to len() in compression-related code by caching the length values in local variables. This optimization reduces function call overhead by storing the length once and reusing it instead of repeatedly calling len() on the same data.
Key changes:
- Cache
len(data)in LZ4 compression encoding - Cache
len(f.buf)in frame finishing logic to avoid multiple length calculations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lz4/lz4.go | Caches len(data) to avoid redundant calls in LZ4 compression encoding |
| frame.go | Caches len(f.buf) to eliminate multiple length calculations in frame finishing |
dkropachev
approved these changes
Aug 11, 2025
dkropachev
requested changes
Aug 11, 2025
dkropachev
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar changes to the Python driver (scylladb/python-driver#520 ), there are redundant calls to len(). Removed them.
Follow-up patch will hopefully change the Encode() functions to accept the length of the buffer, to remove another len() call (just as done in the Python change mentioned above).