Skip to content

Conversation

Gor027
Copy link

@Gor027 Gor027 commented Feb 12, 2023

The default load balancing policy will prefer replicas that are in the local datacenter and in the local rack.
The rack awareness feature is optional, to enable it a local rack should be supplied through configuration by defining the option DefaultDriverOption.LOAD_BALANCING_LOCAL_RACK
basic.load-balancing-policy.local-rack, otherwise it will be disabled and unlike the local datacenter it will not be implicitly fetched from the provided contact points.

@Gor027 Gor027 requested a review from avelanarius February 13, 2023 12:51
@mykaul mykaul changed the title Add rack awareness to default load balancing policy 4.x: Add rack awareness to default load balancing policy Feb 22, 2023
@mykaul
Copy link

mykaul commented May 2, 2023

Any updates?

@mykaul mykaul added this to the Java 4.x Q2-2023 release milestone May 4, 2023
@Gor027 Gor027 force-pushed the rack-awareness branch 8 times, most recently from c632982 to 27da24b Compare June 16, 2023 12:49
@Gor027
Copy link
Author

Gor027 commented Jun 16, 2023

@avelanarius Ping.

@roydahan
Copy link
Collaborator

I think that the tests part should be extended a bit to include more cases.

@malah-akh
Copy link

Hello team,

Are we going to release it in the next 3 days?

@Gor027 Gor027 force-pushed the rack-awareness branch 2 times, most recently from 0686d57 to 1a428dd Compare June 27, 2023 10:53
Gor027 added 2 commits June 27, 2023 13:21
The default load balancing policy will prefer replicas that are in the
local datacenter and in the local rack.
The rack awareness feature is optional, to enable it a local rack should
be supplied through configuration by defining the option
`DefaultDriverOption.LOAD_BALANCING_LOCAL_RACK`
`basic.load-balancing-policy.local-rack`, otherwise it will be
disabled and unlike the local datacenter it will not be implicitly
fetched from the provided contact points.
@Gor027 Gor027 requested a review from Lorak-mmk June 27, 2023 12:16
Copy link

@avelanarius avelanarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also did some additional manual testing with 12-node, 3 datacenter, 6 rack cluster and it all worked correctly.

@avelanarius avelanarius merged commit 437f94b into scylladb:scylla-4.x Jun 27, 2023
@avelanarius
Copy link

avelanarius commented Jun 27, 2023

Hello team,

Are we going to release it in the next 3 days?

@ricardoborenstein
Yes.

Although we have some tests in this PR and I did manual testing, we'll try to do some more testing in the coming 3 days before the release.

@roydahan
Copy link
Collaborator

@avelanarius when you have the time, can you please share the results of the tests and/or how you tell if it works or not.
It may help @fruch later when he adds some SCT scenarios for this.

@avelanarius
Copy link

Hello team,

Are we going to release it in the next 3 days?

4.15.0.1 is now released, which contains this feature. Relevant docs about the feature: https://java-driver.docs.scylladb.com/stable/manual/core/load_balancing/index.html#rack-awareness

@avelanarius
Copy link

@ricardoborenstein ^

@fruch
Copy link

fruch commented Jul 9, 2023

@avelanarius is anyone taking it to cassandra-stress ? (or the equivalent 3.x version ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants