Make ScyllaSniProxyTest tests to wait before checking on events API calls #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calls ScyllaSniProxyTest tests creates a table and right away check of listener APIs. Since listener API is called asynchronously it can fail.
dkropachev
force-pushed
the
358-3x-scyllasniproxytest-tests-are-failing-time-to-time
branch
from
97fc95f to
6b0d045
Compare
Bouncheck
approved these changes
Oct 8, 2024
Bouncheck
left a comment
Bouncheck
left a comment
There was a problem hiding this comment.
LGTM. Could be done using Mockito but since there are atMost(n) checks we would need to wait full time anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #358
ScyllaSniProxyTest tests creates a table and right away check of listener APIs.
Since listener API is called asynchronously it can fail.