3.x: Allow additional scylla.version formats
#396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
requested changes
Dec 5, 2024
driver-core/src/test/java/com/datastax/driver/core/CCMBridge.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/java/com/datastax/driver/core/CCMBridge.java
Outdated
Show resolved
Hide resolved
dkropachev
requested changes
Dec 10, 2024
driver-core/src/test/java/com/datastax/driver/core/CCMBridge.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/java/com/datastax/driver/core/CCMBridge.java
Outdated
Show resolved
Hide resolved
Modifies version parsing logic to try passing the `scylla.version` to the CCM when it can't be parsed as VersionNumber. If CCM manages to run `create` with it, then the usual version number is fetched from `ccm node versionfrombuild` output. To do that we introduce a static version of `execute`. The method body is nearly the same. Functionally should be the same. Previous version now calls the static one.
Bouncheck
force-pushed
the
scylla-3.x-ccmBridge-nonstandard-scylla-versions
branch
from
9e6813f to
e095a13
Compare
dkropachev
reviewed
Dec 11, 2024
dkropachev
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies version parsing logic to try passing the
scylla.versionto theCCM when it can't be parsed as VersionNumber. If CCM manages to run
createwith it, then the usual version number is fetched from
ccm node versionfrombuildoutput.To do that we introduce a static version of
execute. The method body isnearly the same. Functionally should be the same. Previous version now calls
the static one.