3.x: Do not append "-fedora" to os.detected.classifier anymore
#472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `netty-tcnative.artifact` property was changed to `netty-tcnative-boringssl-static` this suffix is no longer a valid configuration. This change skips it and adds notice about required dependency as mentioned at: https://netty.io/wiki/forked-tomcat-native.html#prerequisites-for-statically-linked-netty-tcnative--static
Bouncheck
changed the title
os.detected.classifier anymoreos.detected.classifier anymore
dkropachev
approved these changes
Mar 20, 2025
dkropachev
pushed a commit
that referenced
this pull request
Mar 21, 2025
Since `netty-tcnative.artifact` property was changed to `netty-tcnative-boringssl-static` this suffix is no longer a valid configuration. This change skips it and adds notice about required dependency as mentioned at: https://netty.io/wiki/forked-tomcat-native.html#prerequisites-for-statically-linked-netty-tcnative--static
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
netty-tcnative.artifactproperty was changed tonetty-tcnative-boringssl-staticthis suffix is no longer a valid configuration. This change skips it and adds notice about required dependency as mentioned at:https://netty.io/wiki/forked-tomcat-native.html#prerequisites-for-statically-linked-netty-tcnative--static
Fixes #471