Check port range

Only allow valid TCP port numbers.

Signed-off-by: Alejo Sanchez <[email protected]>

Author: Alejo Sanchez

cassandra/cluster.py

@@ -1151,6 +1151,9 @@ def __init__(self,
                 raise ValueError("Only numeric values are supported for port (%s)" % port)
             port = int(port)
 
+        if port < 1 or port > 65535:
+            raise ValueError("Invalid port number (%s) (1-65535)" % port)
+
         if connection_class is not None:
             self.connection_class = connection_class
 

tests/unit/test_cluster.py

@@ -132,6 +132,12 @@ def test_port_str(self):
             cluster = Cluster(contact_points=['127.0.0.1'], port='string')
 
 
+    def test_port_range(self):
+        for invalid_port in [0, 65536, -1]:
+            with self.assertRaises(ValueError):
+                cluster = Cluster(contact_points=['127.0.0.1'], port=invalid_port)
+
+
 class SchedulerTest(unittest.TestCase):
     # TODO: this suite could be expanded; for now just adding a test covering a ticket