Open
Conversation
This task seems to dump username / password / auth token to the outputted logs. Adding a no_log: true will still show the task running, but remove a great deal of the output.
Collaborator
|
Was going over the "deserted PRs" (sorry, @jbragdon1). |
vladzcloudius
requested changes
May 14, 2025
| --password {{ item.password }} \ | ||
| {% endif %} | ||
| when: cluster_already_added is not defined or cluster_already_added.stdout != "present" | ||
| no_log: true |
Collaborator
There was a problem hiding this comment.
I'd parametrize it. And set it to False by default to preserve the current behavior.
vreniers
reviewed
May 15, 2025
Collaborator
There was a problem hiding this comment.
This PR requires a rebase. The file name was changed to add_cluster.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This task seems to dump username / password / auth token to the outputted logs. Adding a no_log: true will still show the task running, but remove a great deal of the output.
Tested in a local copy