ansible-scylla-node: remove default scylla_seeds#440
Open
vreniers wants to merge 1 commit intoscylladb:masterfrom
Open
ansible-scylla-node: remove default scylla_seeds#440vreniers wants to merge 1 commit intoscylladb:masterfrom
vreniers wants to merge 1 commit intoscylladb:masterfrom
Conversation
The assumption cannot be made that the hostname is DNS resolvable by all nodes in the cluster. It's more appropriate to require that the seed nodes are specified explicitly. Signed-off-by: Vincent Reniers <vincent.reniers@scylladb.com>
vladzcloudius
requested changes
Mar 25, 2025
| # Do not use the below default example if ansible_host is not specified and the hostname is not resolvable by all nodes. | ||
| # | ||
| #scylla_seeds: | ||
| # - "{{ hostvars[groups.scylla.0].ansible_host if 'ansible_host' in hostvars[groups.scylla.0] else groups.scylla.0 }}" |
Collaborator
There was a problem hiding this comment.
If we remove the default then we must either add "if defined" blocks everywhere we use it or add an explicit check that this value is specified early in the play.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assumption cannot be made that the hostname is DNS resolvable by all nodes in the cluster. It's more appropriate to require that the seed nodes are specified explicitly.