sni_proxy: honor the --sni-port command line argument #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruch
force-pushed
the
fix_sni_port_setup
branch
from
7067a04 to
4d000b7
Compare
seems like commit 4d61471 has changed the output of the bundles and they are default to port 9142 that the nodes are using, and not to the port used by the sni_proxy basiclly bypassing the sni_proxy, which broke some of the java-driver tests (python-driver tests aren't broke, since it's not using the command line) Ref: scylladb/java-driver#221
fruch
force-pushed
the
fix_sni_port_setup
branch
from
4d000b7 to
201f106
Compare
this would help fix some issue with the selection of data to diffrent parts of the sni_proxy impemention with out need to parse it again and again by positions
those seemed to be breaking every time it was changed and we don't have any test covering them until now.
since we can't pass a cloudbundle and adddress/port to cqlsh we should add those if the user is passing `--cloudconf` in `cqlsh_options`. this would enable use to write tests, and also write dtest covering this.
|
@Gor027 @Bouncheck can you review, and give it a try on the drivers tests ? to see it doesn't break ? I'll test it on the python-driver |
|
I have run GitHub Actions test workflows of Java driver
|
@Gor027 version 2022.2.7 doesn't exists, I think it was retracted, use 2022.2.6, until 2022.2.8 would be released |
Gor027
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
I tested it with the Rust driver, too. If it is also tested with Python driver, I think it is good to be merged. Also, we should update the CI matrix Scylla and Cassandra versions in Java driver as some versions might not be available anymore. @avelanarius
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems like commit 4d61471 has changed the output of the bundles and they are default to port 9142 that the nodes are using, and not to the port used by the sni_proxy basiclly bypassing the sni_proxy, which broke some of the java-driver tests (python-driver tests aren't broke, since it's not using the command line)
Fixes: scylladb/java-driver#221