fix(monitoring): avoid port conflicts on concurrent restores#14239
Draft
dimakr wants to merge 1 commit intoscylladb:masterfrom
Draft
fix(monitoring): avoid port conflicts on concurrent restores#14239dimakr wants to merge 1 commit intoscylladb:masterfrom
dimakr wants to merge 1 commit intoscylladb:masterfrom
Conversation
dimakr
added
backport/none
Collaborator
✅ Test Summary: PASSED✅ Precommit: PASSED
✅ Tests: PASSED
|
dimakr
force-pushed
the
docker_provision_test_fail
branch
3 times, most recently
from
3bccf2a to
a4dd19c
Compare
When Docker provision tests restore monitoring stack concurrently, they race on container names/ports. On retry, new ports are picked each time, leaving orphan containers that hold the Prometheus DB lock and make all subsequent attempts fail. The change fixes this by selecting ports once before the retry loop, and force-removing containers from prior attempts to ensure clean state on each retry. Fixes: SCT-179
dimakr
force-pushed
the
docker_provision_test_fail
branch
from
a4dd19c to
4a4b861
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Docker provision tests restore monitoring stack concurrently, they race on container names/ports. On retry, new ports are picked each time, leaving
orphan containers that hold the Prometheus DB lock and make all subsequent attempts fail.
The change fixes this by selecting ports once before the retry loop, and force-removing containers from prior attempts to ensure clean state on each retry.
Fixes: SCT-179
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)