chore(plans): move SVG generation to pre-commit hook#14249
Open
fruch wants to merge 1 commit intoscylladb:masterfrom
Open
chore(plans): move SVG generation to pre-commit hook#14249fruch wants to merge 1 commit intoscylladb:masterfrom
fruch wants to merge 1 commit intoscylladb:masterfrom
Conversation
fruch
force-pushed
the
chore/progress-svg-precommit
branch
from
fff24fb to
b8e8190
Compare
Collaborator
✅ Test Summary: PASSED✅ Precommit: PASSED
✅ Tests: PASSED
|
Replace the GitHub Actions workflow for regenerating the progress SVG with a pre-commit hook, since the action lacks push permissions. Fix SVG generator to include trailing newline for end-of-file-fixer compatibility. Update progress.json and MASTER.md to reflect merged PRs (scylladb#13916, scylladb#13887, scylladb#13877, scylladb#13769, scylladb#13629). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fruch
force-pushed
the
chore/progress-svg-precommit
branch
from
b8e8190 to
c9c179f
Compare
Contributor
|
will this be adding .svg automatically to the commits? |
Contributor
Author
It's text... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
progress.ymlworkflow with a pre-commit hook that regenerates the progress SVG whendocs/plans/progress.jsonchanges — the action lacked push permissionsgenerate_progress_svg.pyto include a trailing newline so it doesn't conflict with theend-of-file-fixerhookprogress.jsonandMASTER.mdto reflect 5 merged PRs (Plan: Cassandra Cluster Support in SCT #13916, docs(trigger-matrix): implementation plan for centralized YAML-driven job triggering #13887, docs(config-refactor): add plan for extracting validation and lazy image resolution #13877, docs(plans): Add plan for extracting nemesis #13769, feat(jenkins): i8g ARM64 migration plan, configuration, and Phase 1 job implementation #13629) that were still listed aspending_prTest plan
uv run sct.py pre-commitpasses (hooks ran successfully during commit)progress.json, rungit commit— verify SVG is auto-regeneratedprogress.jsonchanges🤖 Generated with Claude Code