Skip to content

pager: add client-side timeout logic #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+386 −34
Open

pager: add client-side timeout logic #1458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ea0394
pager: introduce timeouts for paging requests
wprzytula Oct 26, 2025
6729160
pager: encapsulate timeout logic
wprzytula Oct 26, 2025
66a0617
integration: write test for timeouts in pager
wprzytula Oct 26, 2025
3014855
proxy: fix typos
wprzytula Oct 26, 2025
0844289
pager: tiny preparatory refactor
wprzytula Oct 29, 2025
4f2e2aa
pager: add timeouts to SingleConnectionPagerWorker
wprzytula Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scylla-proxy/src/proxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,7 +1361,7 @@ impl ProxyWorker {
event_registered_flag: Arc<AtomicBool>,
) {
let shard = self.shard;
self.run_until_interrupted("request_processor", |driver_addr, _, real_addr| async move {
self.run_until_interrupted("response_processor", |driver_addr, _, real_addr| async move {
'mainloop: loop {
match responses_rx.recv().await {
Some(response) => {
Expand All @@ -1374,7 +1374,7 @@ impl ProxyWorker {
let mut guard = response_rules.lock().unwrap();
'_ruleloop: for (i, response_rule) in guard.iter_mut().enumerate() {
if response_rule.0.eval(&ctx) {
info!("Applying rule no={} to request ({} -> {} ({})).", i, DisplayableRealAddrOption(real_addr), driver_addr, DisplayableShard(shard));
info!("Applying rule no={} to response ({} -> {} ({})).", i, DisplayableRealAddrOption(real_addr), driver_addr, DisplayableShard(shard));
debug!("-> Applied rule: {:?}", response_rule);
debug!("-> To response: {:?}", ctx.opcode);
trace!("{:?}", response);
Expand Down
Loading
Loading