Skip to content

Comments

gitignore: ignore directories that match "build*"#2602

Closed
tomershafir wants to merge 1 commit intoscylladb:masterfrom
tomershafir:gitignore-all-build-dir-variants
Closed

gitignore: ignore directories that match "build*"#2602
tomershafir wants to merge 1 commit intoscylladb:masterfrom
tomershafir:gitignore-all-build-dir-variants

Conversation

@tomershafir
Copy link
Contributor

To ease local build versioning with git, like build_old and build_new.

To ease local build versioning with git, like build_old and build_new.
@tomershafir tomershafir marked this pull request as ready for review December 31, 2024 12:51
@p12tic
Copy link
Contributor

p12tic commented Jan 9, 2025

Shouldn't this be part of local configuration using core.excludesFile configuration key?

@tomershafir
Copy link
Contributor Author

I would prefer that seastar specifies that, so it "just works" without target dependency. Also, a global state can be trickier to manage if other projects use different conventions

@xemul xemul closed this in 1404cba Jan 10, 2025
@tomershafir tomershafir deleted the gitignore-all-build-dir-variants branch January 10, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants