-
Notifications
You must be signed in to change notification settings - Fork 33
Updates the server/client architecture to allow for remote servers #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…rita-plugin � Conflicts: � krita.bat � krita_server.py
|
|
sddebz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and thank you for this PR. This is definitely a good feature. The only problem I have with this request is that it seems you removed some lines from krita_diff.py and krita_diff_ui.py. Once this issue is solved I'll merge it.
|
I had to resolve merge conflicts and it looks like some code got accidentally removed. I believe I've added it all back now, and changed the constant MODE_SD_UPSCALE from |
|
So thank you for fixes. I looked at the PR again and I see that it doesn't really work in my Krita. I think the problem is it tries to import requests library. Until now I only used standard python library and Krita's libs. Right now I'm not sure how to proceed. I don't want to force users to do some manual steps like installing request lib in pykrita folder or globally. At the same time I don't see how to easly replace requests with urllib.request for this scenario. So in short, I can't really merge it now because it requires requests library. Maybe you will be able to find a way to remove this depencency or provide a clear and easy way to install missing dependencies for Krita. |
|
To he honest, I was already working on adding remote server support. I was going to just send file as base64 string in json. I think if we don't find a good solution here, I'll be able to add this feature next weekend. But I'll be happy to merge your version if we make sure it will work for everyone. |
|
Oh true, because Krita uses its own Python env you have to copy or link your system libs to Krita. E.g., on Linux: I had tried to use just In that case you could replace /saveimg on the server with one that accepts base64 in the body, it should be as easy as changing line 325 in krita_diff.py to something like this: I didn't test that though, but it's a good idea to workaround the lib issue. I think the fix in What me to try base64 encoding as an alternative? |
|
Well, I would say just let me fix it. I'll have time to do it on saturday. |
|
Any progress on this? My changes still work; I've been using them daily. |
|
I'm sorry. Due to funny actions of my president, I'm currently unable to finish this work. I hope I will be able to look at it this week. |
Many environments (like mine) have my ML environment and Krita client on separate computers. This update now has the server save all images locally and then respond to remote requests to fetch/save images/masks, allowing for the plugin to run remotely.