Modernize Javascript and tool chain #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sderrow
force-pushed
the
modernize
branch
2 times, most recently
from
b682005 to
ff2571f
Compare
sderrow
force-pushed
the
modernize
branch
5 times, most recently
from
6eeabf5 to
11a1b3b
Compare
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
sderrow
force-pushed
the
graphite-base/5
branch
from
e4c7db2 to
44caf90
Compare
sderrow
force-pushed
the
modernize
branch
4 times, most recently
from
271c3c7 to
dd6a959
Compare
sderrow
force-pushed
the
graphite-base/5
branch
from
db27b18 to
80c7345
Compare
sderrow
force-pushed
the
modernize
branch
2 times, most recently
from
3940f50 to
27214fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of bottleneck using modern Javascript since the original is no longer maintained.
I've removed the es5 build since the future is here.
All the tests pass, but only probabilistically. Sometimes you'll run them and they'll all pass. Other times, you'll see a failure. Almost certainly this is due to mismatched expectations around timeouts and intervals and the event loop.
Next step: write it natively in Typescript.