fixup! Snapshot PR: Extract complex default impls from AggregateUDFImpl trait

Author: findepi

datafusion/expr/src/lib.rs

@@ -105,8 +105,10 @@ pub use partition_evaluator::PartitionEvaluator;
 pub use sqlparser;
 pub use table_source::{TableProviderFilterPushDown, TableSource, TableType};
 pub use udaf::{
-    aggregate_doc_sections, AggregateUDF, AggregateUDFImpl, ReversedUDAF,
-    SetMonotonicity, StatisticsArgs,
+    aggregate_doc_sections, udaf_default_display_name, udaf_default_human_display,
+    udaf_default_return_field, udaf_default_schema_name,
+    udaf_default_window_function_display_name, udaf_default_window_function_schema_name,
+    AggregateUDF, AggregateUDFImpl, ReversedUDAF, SetMonotonicity, StatisticsArgs,
 };
 pub use udf::{
     scalar_doc_sections, ReturnFieldArgs, ScalarFunctionArgs, ScalarUDF, ScalarUDFImpl,

datafusion/expr/src/udaf.rs

@@ -779,7 +779,7 @@ impl PartialOrd for dyn AggregateUDFImpl {
     }
 }
 
-fn udaf_default_schema_name<F: AggregateUDFImpl + ?Sized>(
+pub fn udaf_default_schema_name<F: AggregateUDFImpl + ?Sized>(
     func: &F,
     params: &AggregateFunctionParams,
 ) -> Result<String> {
@@ -832,7 +832,7 @@ fn udaf_default_schema_name<F: AggregateUDFImpl + ?Sized>(
     Ok(schema_name)
 }
 
-fn udaf_default_human_display<F: AggregateUDFImpl + ?Sized>(
+pub fn udaf_default_human_display<F: AggregateUDFImpl + ?Sized>(
     func: &F,
     params: &AggregateFunctionParams,
 ) -> Result<String> {
@@ -871,7 +871,7 @@ fn udaf_default_human_display<F: AggregateUDFImpl + ?Sized>(
     Ok(schema_name)
 }
 
-fn udaf_default_window_function_schema_name<F: AggregateUDFImpl + ?Sized>(
+pub fn udaf_default_window_function_schema_name<F: AggregateUDFImpl + ?Sized>(
     func: &F,
     params: &WindowFunctionParams,
 ) -> Result<String> {
@@ -929,7 +929,7 @@ fn udaf_default_window_function_schema_name<F: AggregateUDFImpl + ?Sized>(
     Ok(schema_name)
 }
 
-fn udaf_default_display_name<F: AggregateUDFImpl + ?Sized>(
+pub fn udaf_default_display_name<F: AggregateUDFImpl + ?Sized>(
     func: &F,
     params: &AggregateFunctionParams,
 ) -> Result<String> {
@@ -970,7 +970,7 @@ fn udaf_default_display_name<F: AggregateUDFImpl + ?Sized>(
     Ok(display_name)
 }
 
-fn udaf_default_window_function_display_name<F: AggregateUDFImpl + ?Sized>(
+pub fn udaf_default_window_function_display_name<F: AggregateUDFImpl + ?Sized>(
     func: &F,
     params: &WindowFunctionParams,
 ) -> Result<String> {
@@ -1028,7 +1028,7 @@ fn udaf_default_window_function_display_name<F: AggregateUDFImpl + ?Sized>(
     Ok(display_name)
 }
 
-fn udaf_default_return_field<F: AggregateUDFImpl + ?Sized>(
+pub fn udaf_default_return_field<F: AggregateUDFImpl + ?Sized>(
     func: &F,
     arg_fields: &[FieldRef],
 ) -> Result<FieldRef> {