Skip to content

fix(completion): fix static analysis shellcheck errors #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(completion): fix static analysis shellcheck errors #1108

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1184fcd
fix(completion): fix static analysis shellcheck errors
leagris Jul 31, 2022
550eeb3
fix(compgen): mapfile instead of read -a
leagris Jul 31, 2022
4e97735
fix(posix): make old bash pleased in posix mode
leagris Aug 1, 2022
c295446
fix(bash32): restore bash 3.2 compat
leagris Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contrib/completion/bash/sdk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ __sdkman_complete_command() {
done
;;
install|i|list|ls)
candidates=${SDKMAN_CANDIDATES[@]}
candidates=("${SDKMAN_CANDIDATES[@]}")
;;
env|e)
candidates=("init" "install" "clear")
Expand All @@ -49,7 +49,7 @@ __sdkman_complete_command() {
;;
esac

COMPREPLY=($(compgen -W "${candidates[*]}" -- "$current_word"))
mapfile -t COMPREPLY < <(compgen -W "${candidates[*]}" -- "$current_word")
}

__sdkman_complete_candidate_version() {
Expand All @@ -76,7 +76,7 @@ __sdkman_complete_candidate_version() {
;;
esac

COMPREPLY=($(compgen -W "${candidates[*]}" -- "$candidate_version"))
mapfile -t COMPREPLY < <(compgen -W "${candidates[*]}" -- "$candidate_version")
}

complete -o default -F _sdk sdk
Expand Down