Update the vendor of dragonwell #16
Conversation
|
@eddumelendez Please review the PR, thank you very much! |
|
Hi, this should match the one in sdkman. I haven't seen any in sdkman about it. Can you point me to that change? |
Hi, our company's name is Alibaba, and our jdk is called Alibaba Dragonwell. The original albba is not clear enough, so I want to update the vendor. |
|
the rename doesn't happen in this repo. As I asked already, can you point me to the PR doing the rename? |
Sorry, please tell me which repo should I make changes in? |
@Accelerator1996 理论上这个直接合并就行了，因为 Dragonwell 在 Foojay Disco 里面没有变化。 https://github.com/sdkman/sdkman-candidates 里面都得变更，否则映射不上！ @eddumelendez He's just trying to change the vendor mapping. The albba names didn't make sense in the past. |
| @@ -21,7 +21,7 @@ public class PackageAdapter { | |||
|
|
|||
| private static final Map<String, String> FOOJAY_SDKMAN_JVM_VENDOR_MAPPING = Map.ofEntries( | |||
| entry("corretto", "amzn"), | |||
| entry("dragonwell", "albba"), | |||
| entry("dragonwell", "alibaba"), | |||
There was a problem hiding this comment.
the value albba currently match with the one https://github.com/sdkman/sdkman-candidates/blob/master/app/controllers/JavaListController.scala#L84
There was a problem hiding this comment.
@eddumelendez Thank you for your suggestions. Here are my pull requests in other repos, please help to review them.
sdkman/sdkman-candidates#73
sdkman/sdkman.github.io#96
And I think that the CI error of this PR "sdkman/sdkman-candidates#73" may be caused by the correlation between multiple repos and releases.
No description provided.