Skip to content

fix total time metrics #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

fix total time metrics #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ead5d01
fix total time metrics
xadupre Oct 7, 2025
2ada3be
changelogs
xadupre Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOGS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Change Logs
0.7.14
++++++

* :pr:`252`: adds new set of inputs for task texgt-generation
* :pr:`250`: add variables to track sequence nodes
* :pr:`249`: patches _maybe_broadcast to support a corner case

Expand Down
9 changes: 7 additions & 2 deletions onnx_diagnostic/_command_lines_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,12 +400,17 @@ def get_parser_validate() -> ArgumentParser:

position_ids is usually not needed, they can be removed by adding:

--drop position_ids
--drop position_ids

The behaviour may be modified compare the original configuration,
the following argument can be rope_scaling to dynamic:

--mop \"rope_scaling={'rope_type': 'dynamic', 'factor': 10.0}\""
--mop \"rope_scaling={'rope_type': 'dynamic', 'factor': 10.0}\""

You can profile the command line by running:

pyinstrument -m onnx_diagnostic validate ...
pyinstrument -r html -o profile.html -m onnx_diagnostic validate ...
"""
),
formatter_class=RawTextHelpFormatter,
Expand Down
6 changes: 3 additions & 3 deletions onnx_diagnostic/torch_models/validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,14 +419,14 @@ def validate_model(
such as ``input_empty_cache``
which refers to a set of inputs using an empty cache.
"""
validation_begin = time.perf_counter()
main_validation_begin = time.perf_counter()
model_id, subfolder, same_as_pretrained, use_pretrained = _preprocess_model_id(
model_id,
subfolder,
same_as_pretrained=same_as_pretrained,
use_pretrained=use_pretrained,
)
time_preprocess_model_id = time.perf_counter() - validation_begin
time_preprocess_model_id = time.perf_counter() - main_validation_begin
default_patch = dict(patch_transformers=True, patch_diffusers=True, patch=True)
if isinstance(patch, bool):
patch_kwargs = default_patch if patch else dict(patch=False)
Expand Down Expand Up @@ -921,7 +921,7 @@ def validate_model(
summary.update(summary_valid)

_compute_final_statistics(summary)
summary["time_total"] = time.perf_counter() - validation_begin
summary["time_total"] = time.perf_counter() - main_validation_begin

if verbose:
print("[validate_model] -- done (final)")
Expand Down
Loading