Skip to content

Combine static_code_analysis.yml with release_notes.yml #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
R-Palazzo merged 6 commits into from
Jan 10, 2025
Merged

Combine static_code_analysis.yml with release_notes.yml #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aff86b8
create prepare_release.yml
R-Palazzo Jan 8, 2025
b8652dc
delete release_notes.yml and static_code_analysis.yml
R-Palazzo Jan 8, 2025
197ed4d
try workflow on the issue's branch
R-Palazzo Jan 8, 2025
3ef07e7
trigger the workflow on pushes
R-Palazzo Jan 8, 2025
add62a8
remove trigger on pushes
R-Palazzo Jan 8, 2025
27e4398
change default branch to try workflow_dispatch
R-Palazzo Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions .github/workflows/release_notes.yml → .github/workflows/prepare_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: Release Notes Generator
name: Release Prep

on:
workflow_dispatch:
inputs:
branch:
description: 'Branch to merge release notes into.'
description: 'Branch to merge release notes and code analysis into.'
required: true
default: 'main'
default: 'issue-421-prepare-release'
version:
description:
'Version to use for the release. Must be in format: X.Y.Z.'
Expand All @@ -15,7 +15,7 @@ on:
'Date of the release. Must be in format YYYY-MM-DD.'

jobs:
releasenotesgeneration:
preparerelease:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -28,6 +28,8 @@ jobs:
run: |
python -m pip install --upgrade pip
python -m pip install requests==2.31.0
python -m pip install bandit==1.7.7
python -m pip install .[test]

- name: Generate release notes
env:
Expand All @@ -37,16 +39,19 @@ jobs:
-v ${{ inputs.version }}
-d ${{ inputs.date }}

- name: Save static code analysis
run: bandit -r . -x ./tests,./scripts,./build -f txt -o static_code_analysis.txt --exit-zero

Comment on lines +42 to +44
Copy link
Contributor

@amontanez24 amontanez24 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for all of these can we manually trigger it and see what the code analysis looks like? I've had trouble before where some files weren't being filtered out properly so I just want to make sure

- name: Create pull request
id: cpr
uses: peter-evans/create-pull-request@v4
with:
token: ${{ secrets.GH_ACCESS_TOKEN }}
commit-message: Release notes for v${{ inputs.version }}
commit-message: Prepare release for v${{ inputs.version }}
author: "github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>"
committer: "github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>"
title: v${{ inputs.version }} Release Notes
body: "This is an auto-generated PR to update the release notes."
branch: release-notes
title: v${{ inputs.version }} Release Preparation
body: "This is an auto-generated PR to prepare the release."
branch: prepared-release
branch-suffix: short-commit-hash
base: ${{ inputs.branch }}
35 changes: 0 additions & 35 deletions .github/workflows/static_code_analysis.yml
View file
Open in desktop

This file was deleted.

Loading