Error if continuous training data contains null values #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
+ Coverage 85.25% 85.46% +0.20%
==========================================
Files 10 11 +1
Lines 780 791 +11
==========================================
+ Hits 665 676 +11
Misses 115 115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frances-h
approved these changes
Jan 15, 2025
tests/unit/synthesizer/test_ctgan.py
Outdated
Comment on lines
301
to
318
| Setup: | ||
| - Create dataframe with a continuous column | ||
| - Create numpy array with same data | ||
| - Create dataframe with a discrete column | ||
| - Create numpy array with a discrete column | ||
| Input: | ||
| - train_data = 2-dimensional numpy array or a pandas.DataFrame | ||
| - discrete_columns = list of strings or integers | ||
| Output: | ||
| None | ||
| Side Effects: | ||
| - Raises error if a continuous column contains a null value. | ||
| Note: | ||
| - could create another function for numpy array |
Contributor
There was a problem hiding this comment.
minor: this is an old doc style we don't use anymore, you can just have the summary for new tests
R-Palazzo
approved these changes
Jan 15, 2025
| discrete_columns = ['discrete'] | ||
|
|
||
| ctgan = CTGAN(epochs=1) | ||
| with pytest.raises(InvalidDataError): |
Contributor
There was a problem hiding this comment.
Add # Run and Assert
You could also check the error message here
Li1Davey
added a commit
to Li1Davey/CondFairGen
that referenced
this pull request
Jun 7, 2025
CTGAN error during fit if continuous training data contains null values (sdv-dev#428)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414
CU-86b2pdt0b