Skip to content

Conversation

@R-Palazzo
Copy link
Contributor

Resolve #462
CU-86b6m8pmt

@R-Palazzo R-Palazzo requested a review from a team as a code owner September 24, 2025 15:07
@sdv-team
Copy link
Contributor

@R-Palazzo R-Palazzo removed the request for review from a team September 24, 2025 15:28
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.20%. Comparing base (ccd23ca) to head (4538bce).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ctgan/synthesizers/_utils.py 87.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   85.46%   86.20%   +0.74%     
==========================================
  Files          11       12       +1     
  Lines         791      812      +21     
==========================================
+ Hits          676      700      +24     
+ Misses        115      112       -3     
Flag Coverage Δ
integration 85.59% <81.08%> (+0.25%) ⬆️
unit 69.70% <75.67%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@R-Palazzo R-Palazzo self-assigned this Sep 24, 2025
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I noticed a potential issue with backwards compatibility. If you load a synthesizer from before this change, they won't be able to access the _enable_gpu parameter right?

@R-Palazzo R-Palazzo requested a review from gsheni October 2, 2025 13:55
@R-Palazzo R-Palazzo merged commit bb59e91 into main Oct 2, 2025
57 checks passed
@R-Palazzo R-Palazzo deleted the issue-462-enable-gpu branch October 2, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable GPU usage for MacOS (using MPS)

6 participants