Merged
Conversation
Contributor
|
Task linked: CU-86b3gbr2j RDT - Add |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 2233 2296 +63
=========================================
+ Hits 2233 2296 +63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frances-h
force-pushed
the
issue-929-LogitScaler-transformer
branch
from
f1e48fe to
e06247d
Compare
frances-h
requested review from
gsheni,
pvk-developer and
rwedge
and removed request for
a team
pvk-developer
requested changes
Jan 23, 2025
gsheni
reviewed
Jan 23, 2025
rwedge
reviewed
Jan 23, 2025
Contributor
rwedge
left a comment
rwedge
left a comment
There was a problem hiding this comment.
Can we test a scenario where learn_rounding_scheme is True
frances-h
force-pushed
the
issue-929-LogitScaler-transformer
branch
from
b9eb720 to
199d2c0
Compare
frances-h
force-pushed
the
issue-929-LogitScaler-transformer
branch
from
199d2c0 to
fc272bf
Compare
rwedge
approved these changes
Jan 24, 2025
gsheni
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #929
CU-86b3gbr2j