Skip to content

Conversation

@fealho
Copy link
Member

@fealho fealho commented Nov 14, 2025

CU-86b7b4wnj, Resolve #484

@fealho fealho requested a review from a team as a code owner November 14, 2025 18:06
@fealho fealho requested review from sarahmish and removed request for a team November 14, 2025 18:06
@sdv-team
Copy link
Contributor

@fealho fealho requested a review from R-Palazzo November 14, 2025 18:06
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.04%. Comparing base (ddd3dcf) to head (436fe70).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   76.04%   76.04%           
=======================================
  Files          30       30           
  Lines        2371     2371           
=======================================
  Hits         1803     1803           
  Misses        568      568           
Flag Coverage Δ
integration 61.60% <ø> (ø)
unit 71.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fealho fealho force-pushed the issue-484-root-path branch from b22838c to a29ee75 Compare November 17, 2025 15:00
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I tested it locally and it worked 👍

@fealho fealho merged commit d4ae9e2 into main Nov 17, 2025
44 checks passed
@fealho fealho deleted the issue-484-root-path branch November 17, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When running a benchmark locally, the additional_datasets_folder path should be the root path

5 participants