Skip to content

Conversation

@fealho
Copy link
Member

@fealho fealho commented Nov 24, 2025

CU-86b7ck0t5, Resolve #488

@sdv-team
Copy link
Contributor

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 90.76923% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.98%. Comparing base (c13ed60) to head (3a78dba).
⚠️ Report is 1 commits behind head on feature_branch/mutli_table_benchmark.

Files with missing lines Patch % Lines
sdgym/datasets.py 82.35% 3 Missing ⚠️
sdgym/result_explorer/result_handler.py 87.50% 3 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                            @@
##           feature_branch/mutli_table_benchmark     #505      +/-   ##
========================================================================
+ Coverage                                 77.75%   77.98%   +0.23%     
========================================================================
  Files                                        30       30              
  Lines                                      2580     2621      +41     
========================================================================
+ Hits                                       2006     2044      +38     
- Misses                                      574      577       +3     
Flag Coverage Δ
integration 63.58% <52.30%> (-0.18%) ⬇️
unit 72.14% <89.23%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fealho fealho force-pushed the issue-488-multi-table-result-explorer branch from 08ae180 to df54c6f Compare November 26, 2025 15:16
@fealho fealho changed the base branch from main to issue-486-add-benchmark_multi_table_function November 26, 2025 15:16
@pvk-developer pvk-developer force-pushed the issue-486-add-benchmark_multi_table_function branch from df5e11c to c51dc98 Compare November 26, 2025 17:10
@R-Palazzo
Copy link
Contributor

Hi @fealho, coud you update this folder to match the new single_table/multi_table structure?
I think anything that is here can go into single_table.

To generate the multi-table examples, you could run benchmark_multi_table() with output_destination=/tests/integration/result_explorer/_benchmark_results so it creates the folder structure.

Then you can manually change the date to create multiple examples that you can test with some integration tests.

@fealho fealho force-pushed the issue-488-multi-table-result-explorer branch 2 times, most recently from 2da47a7 to 688666d Compare December 1, 2025 15:20
@pvk-developer pvk-developer force-pushed the issue-486-add-benchmark_multi_table_function branch from 561b1cb to 15288cf Compare December 1, 2025 16:36
@R-Palazzo
Copy link
Contributor

@fealho if you want to try out your changes for results saved on AWS you can use:
output_destination = 's3://sdgym-benchmark/Debug/'

I ran small single-table and multi-table benchmark with the new structure. You can see the folders here:

@fealho fealho force-pushed the issue-488-multi-table-result-explorer branch 4 times, most recently from 5d1162b to a985b08 Compare December 2, 2025 18:23
Base automatically changed from issue-486-add-benchmark_multi_table_function to feature_branch/mutli_table_benchmark December 3, 2025 08:32
@fealho fealho force-pushed the issue-488-multi-table-result-explorer branch 2 times, most recently from 9e2b28f to 4c87a30 Compare December 3, 2025 16:51
@fealho fealho marked this pull request as ready for review December 3, 2025 19:09
@fealho fealho requested a review from a team as a code owner December 3, 2025 19:09
@fealho fealho requested review from R-Palazzo, gsheni and pvk-developer and removed request for a team and gsheni December 3, 2025 19:09
@fealho fealho requested a review from pvk-developer December 4, 2025 02:48
@fealho fealho force-pushed the issue-488-multi-table-result-explorer branch from 9a97ea3 to ba3482b Compare December 4, 2025 04:11
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just remove the commented line

Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

I just have a few questions but I tested it locally and on aws, it's working pretty well 👍


_BASELINE_BY_MODALITY = {
'single_table': SYNTHESIZER_BASELINE,
'multi_table': 'MultiTableUniformSynthesizer',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fealho can you ask in the Team-Engineering channel which synthesizer we should use as the baseline for multi-table here?

Just to make sure everything is as expected. With this implementation it will be easy to update it in the future 👍

@fealho fealho requested a review from R-Palazzo December 4, 2025 17:10
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

After fixing the tests it should be good to go

@fealho fealho force-pushed the issue-488-multi-table-result-explorer branch 2 times, most recently from 2077d3c to 5d266a8 Compare December 7, 2025 02:01
@fealho fealho force-pushed the issue-488-multi-table-result-explorer branch from 5d266a8 to 3a78dba Compare December 7, 2025 02:35
@fealho fealho merged commit 11d231e into feature_branch/mutli_table_benchmark Dec 8, 2025
44 checks passed
@fealho fealho deleted the issue-488-multi-table-result-explorer branch December 8, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add multi table support to ResultsExplorer

5 participants