Skip to content

Conversation

@R-Palazzo
Copy link
Contributor

@R-Palazzo R-Palazzo commented Nov 28, 2025

Resolve #487
CU-86b7cju6c

I tested it on aws with HSASynthesizer, IndependentSynthesizer, HMASynthesizer and MultiTableUniformSynthesizer here

@R-Palazzo R-Palazzo self-assigned this Nov 28, 2025
@R-Palazzo R-Palazzo requested a review from a team as a code owner November 28, 2025 15:28
@sdv-team
Copy link
Contributor

@R-Palazzo R-Palazzo removed the request for review from a team November 28, 2025 15:28
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.75%. Comparing base (e14f7ff) to head (b03bd09).

Files with missing lines Patch % Lines
sdgym/result_writer.py 10.00% 9 Missing ⚠️
sdgym/benchmark.py 82.35% 3 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                            @@
##           feature_branch/mutli_table_benchmark     #507      +/-   ##
========================================================================
- Coverage                                 77.98%   77.75%   -0.24%     
========================================================================
  Files                                        30       30              
  Lines                                      2557     2580      +23     
========================================================================
+ Hits                                       1994     2006      +12     
- Misses                                      563      574      +11     
Flag Coverage Δ
integration 63.75% <14.81%> (-0.50%) ⬇️
unit 71.82% <55.55%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pvk-developer pvk-developer force-pushed the issue-486-add-benchmark_multi_table_function branch from 561b1cb to 15288cf Compare December 1, 2025 16:36
@R-Palazzo R-Palazzo force-pushed the issue-487-benchmark_mutli_table_aws branch from f4ae85b to 684a40f Compare December 2, 2025 09:40
Base automatically changed from issue-486-add-benchmark_multi_table_function to feature_branch/mutli_table_benchmark December 3, 2025 08:32
@R-Palazzo R-Palazzo force-pushed the issue-487-benchmark_mutli_table_aws branch from 1772e76 to cbafe41 Compare December 3, 2025 09:33
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one question

@R-Palazzo R-Palazzo merged commit 515bc2b into feature_branch/mutli_table_benchmark Dec 4, 2025
36 of 44 checks passed
@R-Palazzo R-Palazzo deleted the issue-487-benchmark_mutli_table_aws branch December 4, 2025 16:35
R-Palazzo added a commit that referenced this pull request Dec 8, 2025
R-Palazzo added a commit that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants