RealTabFormer 0.2.4 causes integration to fail#524
Merged
Conversation
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
=======================================
Coverage 76.71% 76.71%
=======================================
Files 30 30
Lines 2456 2456
=======================================
Hits 1884 1884
Misses 572 572
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fealho
approved these changes
Jan 6, 2026
amontanez24
reviewed
Jan 7, 2026
Contributor
amontanez24
left a comment
There was a problem hiding this comment.
Can we file an issue on their repo?
Contributor
Author
@amontanez24 yes I filed it: |
amontanez24
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #523
CU-86b81pd3u
Early in
fit()there is a call to _train_with_sensitivity that leads to a few inconsistencies:In
_train_with_sensitivitythere are:While
gen_kwargsis None by default. This is the error of the issue.Then if
save_full_every_epochis not 0 then we try to save the model at some epoch. Their save method expect anself.experiment_idto be set while the attribute is set at the end offit()only, so it crashes. The default value forsave_full_every_epochis 5I hope they will fix those inconsistencies in future releases so we can return to the previous implementation.
@amontanez24 This highlights a case we might consider in the future, distinguishing model parameters from
fit()/sample()parameters when defining awrapper/variant. But I think it's out of scope for this issue.