-
Notifications
You must be signed in to change notification settings - Fork 50
Add a violin plot visualizations to compare a pair of columns #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
=======================================
Coverage 95.65% 95.66%
=======================================
Files 115 115
Lines 4581 4590 +9
=======================================
+ Hits 4382 4391 +9
Misses 199 199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visuals are looking good!
As discussed in the eng meeting today, could you check what happens if there are different proportions of real vs. synthetic data? For example, if you sample synthetic data to be 5x the size of the real data, will the violin plot for synthetic data be much fatter than the real data? Ideally we don't want that. We want the plots to be normalized within the respective dataset (real or synthetic).
pvk-developer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @npatki thanks for pointing this out. |
|
Great @R-Palazzo -- looks good to me! |

CU-86b4g8r3b
Resolve #759
Here are the visuals; let me know if they work. (For Figs 1 and 3, I placed my mouse over the violin to see what is shown.) @npatki


