Skip to content

Conversation

@fealho
Copy link
Member

@fealho fealho commented Nov 5, 2024

CU-86b2jarvu, Resolve #2266.

@sdv-team
Copy link
Contributor

sdv-team commented Nov 5, 2024

@fealho fealho force-pushed the issue-2266-rounding-warning branch from e8f78be to 863b29e Compare November 6, 2024 17:39
@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (0fe0123) to head (852e01b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2279   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          58       58           
  Lines        6034     6043    +9     
=======================================
+ Hits         5952     5961    +9     
  Misses         82       82           
Flag Coverage Δ
integration 82.19% <100.00%> (+0.02%) ⬆️
unit 97.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho marked this pull request as ready for review November 6, 2024 18:22
@fealho fealho requested a review from a team as a code owner November 6, 2024 18:22
@fealho fealho requested review from gsheni and removed request for a team November 6, 2024 18:22
@fealho fealho requested a review from frances-h November 6, 2024 18:23
@fealho fealho merged commit 4d56fe7 into main Nov 12, 2024
@fealho fealho deleted the issue-2266-rounding-warning branch November 12, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to turn off rounding scheme for a column (need a warning)

5 participants