Ensure HMASynthesizer utilizes the numerical_distributions set through set_table_parameters
#2659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
==========================================
+ Coverage 98.13% 98.14% +0.01%
==========================================
Files 70 70
Lines 7487 7490 +3
==========================================
+ Hits 7347 7351 +4
+ Misses 140 139 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fealho
requested review from
frances-h and
amontanez24
and removed request for
gsheni
frances-h
approved these changes
Aug 29, 2025
amontanez24
reviewed
Aug 29, 2025
Comment on lines
+287
to
+290
| if numerical_distributions: | ||
| existing = getattr(synthesizer, 'numerical_distributions', {}) or {} | ||
| merged = {**existing, **numerical_distributions} | ||
| synthesizer._set_numerical_distributions(merged) |
There was a problem hiding this comment.
doesn't this function only apply to the child table parameter columns?
There was a problem hiding this comment.
That is what we want. The issue is that _set_numerical_distributions overwrites the existing numerical_distributions attribute, so the existing distributions the user chose get erased.
frances-h
approved these changes
Sep 2, 2025
amontanez24
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b68xxqa, Resolve #2648