Skip to content

Exclude Faker version 37.11.0 to fix tests on python 3.9#2720

Merged
amontanez24 merged 6 commits intomainfrom
fix-tests
Oct 15, 2025
Merged

Exclude Faker version 37.11.0 to fix tests on python 3.9#2720
amontanez24 merged 6 commits intomainfrom
fix-tests

Conversation

@R-Palazzo
Copy link
Copy Markdown
Contributor

@R-Palazzo R-Palazzo commented Oct 14, 2025

resolves #2725

This PR also bumps the minimum version of RDT to 1.18.2, which resolves a bug in Faker

@R-Palazzo R-Palazzo self-assigned this Oct 14, 2025
@R-Palazzo R-Palazzo requested a review from a team as a code owner October 14, 2025 13:12
@R-Palazzo R-Palazzo removed the request for review from a team October 14, 2025 13:13
@sdv-team
Copy link
Copy Markdown
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.17%. Comparing base (ae6e1c0) to head (222aa60).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2720      +/-   ##
==========================================
+ Coverage   97.00%   98.17%   +1.17%     
==========================================
  Files          74       74              
  Lines        7770     7770              
==========================================
+ Hits         7537     7628      +91     
+ Misses        233      142      -91     
Flag Coverage Δ
integration 76.06% <ø> (?)
unit 97.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@R-Palazzo R-Palazzo changed the title Fix tests by capping Faker to versions below 37.11.0 Exclude Faker version 37.11.0 to fix tests on python 3.9 Oct 14, 2025
@sdv-team
Copy link
Copy Markdown
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@sdv-team
Copy link
Copy Markdown
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@amontanez24 amontanez24 requested a review from frances-h October 15, 2025 20:42
Copy link
Copy Markdown
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@amontanez24 amontanez24 merged commit ab196b8 into main Oct 15, 2025
47 checks passed
@amontanez24 amontanez24 deleted the fix-tests branch October 15, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimum tests failing - OSError: [WinError 1114] A dynamic link library (DLL) initialization routine failed

5 participants