Add bucket and credentials parameter to download_demo #2748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2748 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 72 73 +1
Lines 8015 8022 +7
=======================================
+ Hits 7863 7870 +7
Misses 152 152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amontanez24
commented
Nov 18, 2025
|
|
||
| from sdv.datasets import demo, local | ||
|
|
||
| __all__ = ['demo', 'local'] |
Contributor
Author
There was a problem hiding this comment.
this was needed so that I could load the add-ons on Enterprise
amontanez24
requested review from
fealho and
frances-h
and removed request for
sarahmish
fealho
approved these changes
Nov 18, 2025
| s3_bucket_name (str): | ||
| The name of the bucket to download from. Only 'sdv-datasets-public' is supported in | ||
| SDV Community. SDV Enterprise is required for other buckets. | ||
| credentials (str): |
Member
There was a problem hiding this comment.
dict, not str. This happens in all docstrings.
frances-h
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2747