Conversation
Most vara-* commands now support `tui` as a subcommand which opens a text-based UI for selecting command line parameters.
…handling. Many of the checks are not necessary anymore because our config management takes care of managing folders much better.
vulder
left a comment
vulder
left a comment
There was a problem hiding this comment.
Do I understand this correctly, this is "opt-in" as in one can use the CLI as is, without changes and if wanted with the clicky UI?
PS: also some tests seem not to be happy :D
| get_value_or_default( | ||
| vara_cfg()["paper_config"], "folder", | ||
| str(get_varats_base_folder()) | ||
| ) | ||
| ) | ||
| if not (pc_folder_path.exists() and pc_folder_path.is_dir()): | ||
| LOG.error( | ||
| f"Paper config folder not set: {pc_folder_path} " | ||
| "(Path does not exist or is no directory)." | ||
| ) | ||
| return |
There was a problem hiding this comment.
Do we no longer need the checks here?
There was a problem hiding this comment.
No, because by now we take care of creating these directories whenever we save the config.
There was a problem hiding this comment.
And the config folder has a sane default value set.
Yes, this basically adds a new subcommand
I have no idea why. That test initially also failed on my machine but for a different reason. All tests pass when I execute them locally. |
The reason for the failing test was that the CLI parameters are generated at parse-time. Since the test modified the available choices of such an option, we need to reload the driver module for that change to take effect at the CLI level.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## vara-dev #870 +/- ##
============================================
+ Coverage 68.43% 68.45% +0.02%
============================================
Files 340 340
Lines 26627 26635 +8
============================================
+ Hits 18221 18233 +12
+ Misses 8406 8402 -4 ☔ View full report in Codecov by Sentry. |
3 participants
Most vara-* commands now support
tuias a subcommand which opens a text-based UI for selecting command line parameters.Some limitations apply:
vara-runis not supported because arguments do not play nice with command groups in clickvara-plotandvara-tablerequire support forclick.MultiCommand(Add support for click.MultiCommand Textualize/trogon#71)trogoncontains some more small bugs that limit usability. I opened PRs for them, but until they are merged, you can use the following branch for testing: https://github.com/boehmseb/trogon/tree/trogonFixes