Fix PHPUnit shim arg parsing for DB test runner (--dsn with space-separated value) - #80
Merged
Merged
Conversation
Co-authored-by: se7enxweb <51429274+se7enxweb@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Database tests (mysql, PHP 8.3)
Fix PHPUnit shim arg parsing for DB test runner (Aug 18, 2026
--dsn with space-separated value)
se7enxweb
marked this pull request as ready for review
August 18, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Database tests (mysql, PHP 8.3)workflow fails before test execution because the legacy PHPUnit command shim forwards--dsnto PHPUnit 11 as an unknown option. The failure is triggered bytests/runtests.php --dsn <value>(space-separated form), which the shim did not consume.Root cause
PHPUnit_TextUI_Commandshim intests/bootstrap.phponly handled:--opt=value--flag--opt valuefor options declared with=(e.g.dsn=), so--dsnleaked to PHPUnit.Change: shim option parser
run()argument iteration to index-based parsing.--dsn=value--dsn value--db-per-test) remains unchanged.Change: focused regression coverage
tests/tests/lib/ezutils/PHPUnitTextUICommandShimTest.php.--dsnforms and asserts the option is consumed by the shim (not treated as unknown by PHPUnit).