monitor: fix patched variables to not be static#260
Merged
Ivan-Velickovic merged 1 commit intomainfrom Jan 9, 2025
Merged
Conversation
These need to be visible in the final object and hence should not be static. This caused an issue with 9a8aba7 when building in release mode since vm_names is only used in debug mode and so the compiler was (understandably) optimising it out. Signed-off-by: Ivan-Velickovic <i.velickovic@unsw.edu.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These need to be visible in the final object and hence should not be static.
This caused an issue with 9a8aba7 when building in release mode since vm_names is only used in debug mode and so the compiler was (understandably) optimising it out.