loader: fix qemu GIC addresses#279
Merged
Ivan-Velickovic merged 1 commit intoseL4:mainfrom Feb 13, 2025
midnightveil:qemu-fix-gic-base-address
Merged
loader: fix qemu GIC addresses#279Ivan-Velickovic merged 1 commit intoseL4:mainfrom midnightveil:qemu-fix-gic-base-address
Ivan-Velickovic merged 1 commit intoseL4:mainfrom
midnightveil:qemu-fix-gic-base-address
Conversation
Running qemu with -d guest_errors would previously print out
LDR|INFO: Setting all interrupts to Group 1
LDR|INFO: GICv2 ITLinesNumber: 0x00000000
gic_cpu_write: Bad offset 80
gicv2m_write: Bad offset 4
The first write is supposed to be into the GIC_DIST region, then the
second into the GIC_CPU region. Cross referencing to QEMU [1], the GIC
addresses in loader.c are incorrect. Now microkit prints:
LDR|INFO: Setting all interrupts to Group 1
LDR|INFO: GICv2 ITLinesNumber: 0x00000008
The generated seL4 devices_gen.h from the DTS is correct, this is purely
a microkit issue.
[1]: https://github.com/qemu/qemu/blame/de278e54/hw/arm/virt.c#L164-L165
Signed-off-by: julia <git.ts@trainwit.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running qemu with -d guest_errors would previously print out
The first write is supposed to be into the GIC_DIST region, then the second into the GIC_CPU region. Cross referencing to QEMU 1, the GIC addresses in loader.c are incorrect. Now microkit prints:
The generated seL4 devices_gen.h from the DTS is correct, this is purely a microkit issue.