refactor: replace kubectl operation with k8s apiclient call#1745
Open
allencloud wants to merge 1 commit intosealerio:mainfrom
Open
refactor: replace kubectl operation with k8s apiclient call#1745allencloud wants to merge 1 commit intosealerio:mainfrom
allencloud wants to merge 1 commit intosealerio:mainfrom
Conversation
Signed-off-by: Allen Sun <shlallen1990@gmail.com>
b669a17 to
011c7d4
Compare
| // Its data is from KubeadmConfig input from Clusterfile and KubeadmConfig in ClusterImage. | ||
| *kubeadm.KubeadmConfig | ||
| *Config | ||
| // *Config |
Member
There was a problem hiding this comment.
Feel confused about the KubeadmConfigFromClusterfile. I notice that "*kubeadm.KubeadmConfig" above is used to setup the final cluster, but what is KubeadmConfigFromClusterfile capable of?
Member
Author
There was a problem hiding this comment.
I think it is because that we lack the design of how many ways we allow to input KubeadmConfig to a cluster instance. If the sealer policy allows to input KubeadmConfig from Clusterfile, then KubeadmConfigFromClusterfile is useful.
I wish to make it strictly enough when we are evolving, otherwise it may be out of control. Still be design problem, I think. @justadogistaken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun shlallen1990@gmail.com
Describe what this PR does / why we need it
RemoteApplyYaml,RemoteCmdGetNetworkInterface,RemoteCmdExistNetworkInterface;k8s.Clientwhen executingkubectlcommand, likekubectl delete node xxx,kubectl get nodes; After this pull request, there are still some kubectl command there, likekubectl drainandkubectl uncordonin upgrade operation. I found that k8s.Client has not containeddrainanduncordoncommand, and we should use another kubernetes/kubectl package to cover the above both.isHostNameintoisHostInExistingClusterto be more readable.Does this pull request fix one issue?
none
Describe how you did it
none
Describe how to verify it
none
Special notes for reviews